mirror of
https://github.com/shareAI-lab/analysis_claude_code.git
synced 2026-06-21 04:33:36 +08:00
fix(s04): use early-continue idiom in problem code block
The problem block used a nested `if block.type == "tool_use":` while the solution block and code.py use `if block.type != "tool_use": continue`. This made the problem->solution diff show two changes instead of the one the section teaches (the README states only one place in the loop changed). Align all three README variants (zh/en/ja) to the early-continue idiom.
This commit is contained in:
@@ -21,13 +21,14 @@ def agent_loop(messages):
|
||||
while True:
|
||||
# ... LLM call ...
|
||||
for block in response.content:
|
||||
if block.type == "tool_use":
|
||||
log_to_file(block) # added a line
|
||||
check_permission(block) # added a line
|
||||
notify_slack(block) # added another line
|
||||
output = execute(block)
|
||||
auto_git_add(block) # yet another line
|
||||
# ... the loop is unrecognizable
|
||||
if block.type != "tool_use":
|
||||
continue
|
||||
log_to_file(block) # added a line
|
||||
check_permission(block) # added a line
|
||||
notify_slack(block) # added another line
|
||||
output = execute(block)
|
||||
auto_git_add(block) # yet another line
|
||||
# ... the loop is unrecognizable
|
||||
```
|
||||
|
||||
What you want to extend is the Agent's behavior, but what you're modifying is the loop itself. The loop should be a stable core; extensions should hang on the outside.
|
||||
|
||||
Reference in New Issue
Block a user