From 950378a29f22796ce42bc41f2365b1019de80b83 Mon Sep 17 00:00:00 2001 From: bear Date: Mon, 23 Mar 2026 20:24:42 +0800 Subject: [PATCH] fix: remove hardcoded assistant acks after system message injection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit s08/s09/s10/s11/s_full inject background-results and inbox as user messages before LLM calls. The paired hardcoded assistant "Noted..." responses were unnecessary — consecutive user messages work fine and the fake acks added noise with no functional value. Affected: agents/s08, s09, s10, s11, s_full + docs (zh/en/ja s08, s09) --- agents/s08_background_tasks.py | 1 - agents/s09_agent_teams.py | 4 ---- agents/s10_team_protocols.py | 4 ---- agents/s11_autonomous_agents.py | 4 ---- agents/s_full.py | 2 -- docs/en/s08-background-tasks.md | 2 -- docs/en/s09-agent-teams.md | 2 -- docs/ja/s08-background-tasks.md | 2 -- docs/ja/s09-agent-teams.md | 2 -- docs/zh/s08-background-tasks.md | 2 -- docs/zh/s09-agent-teams.md | 2 -- 11 files changed, 27 deletions(-) diff --git a/agents/s08_background_tasks.py b/agents/s08_background_tasks.py index e006ccc..5a574a1 100644 --- a/agents/s08_background_tasks.py +++ b/agents/s08_background_tasks.py @@ -194,7 +194,6 @@ def agent_loop(messages: list): f"[bg:{n['task_id']}] {n['status']}: {n['result']}" for n in notifs ) messages.append({"role": "user", "content": f"\n{notif_text}\n"}) - messages.append({"role": "assistant", "content": "Noted background results."}) response = client.messages.create( model=MODEL, system=SYSTEM, messages=messages, tools=TOOLS, max_tokens=8000, diff --git a/agents/s09_agent_teams.py b/agents/s09_agent_teams.py index a404271..53a358a 100644 --- a/agents/s09_agent_teams.py +++ b/agents/s09_agent_teams.py @@ -350,10 +350,6 @@ def agent_loop(messages: list): "role": "user", "content": f"{json.dumps(inbox, indent=2)}", }) - messages.append({ - "role": "assistant", - "content": "Noted inbox messages.", - }) response = client.messages.create( model=MODEL, system=SYSTEM, diff --git a/agents/s10_team_protocols.py b/agents/s10_team_protocols.py index 5f45c1f..ef57c45 100644 --- a/agents/s10_team_protocols.py +++ b/agents/s10_team_protocols.py @@ -431,10 +431,6 @@ def agent_loop(messages: list): "role": "user", "content": f"{json.dumps(inbox, indent=2)}", }) - messages.append({ - "role": "assistant", - "content": "Noted inbox messages.", - }) response = client.messages.create( model=MODEL, system=SYSTEM, diff --git a/agents/s11_autonomous_agents.py b/agents/s11_autonomous_agents.py index 5eabdb9..99eb23b 100644 --- a/agents/s11_autonomous_agents.py +++ b/agents/s11_autonomous_agents.py @@ -515,10 +515,6 @@ def agent_loop(messages: list): "role": "user", "content": f"{json.dumps(inbox, indent=2)}", }) - messages.append({ - "role": "assistant", - "content": "Noted inbox messages.", - }) response = client.messages.create( model=MODEL, system=SYSTEM, diff --git a/agents/s_full.py b/agents/s_full.py index 628aa81..5f5877d 100644 --- a/agents/s_full.py +++ b/agents/s_full.py @@ -664,12 +664,10 @@ def agent_loop(messages: list): if notifs: txt = "\n".join(f"[bg:{n['task_id']}] {n['status']}: {n['result']}" for n in notifs) messages.append({"role": "user", "content": f"\n{txt}\n"}) - messages.append({"role": "assistant", "content": "Noted background results."}) # s10: check lead inbox inbox = BUS.read_inbox("lead") if inbox: messages.append({"role": "user", "content": f"{json.dumps(inbox, indent=2)}"}) - messages.append({"role": "assistant", "content": "Noted inbox messages."}) # LLM call response = client.messages.create( model=MODEL, system=SYSTEM, messages=messages, diff --git a/docs/en/s08-background-tasks.md b/docs/en/s08-background-tasks.md index ffd9333..5a98f21 100644 --- a/docs/en/s08-background-tasks.md +++ b/docs/en/s08-background-tasks.md @@ -81,8 +81,6 @@ def agent_loop(messages: list): messages.append({"role": "user", "content": f"\n{notif_text}\n" f""}) - messages.append({"role": "assistant", - "content": "Noted background results."}) response = client.messages.create(...) ``` diff --git a/docs/en/s09-agent-teams.md b/docs/en/s09-agent-teams.md index 34b54b3..9f19723 100644 --- a/docs/en/s09-agent-teams.md +++ b/docs/en/s09-agent-teams.md @@ -93,8 +93,6 @@ def _teammate_loop(self, name, role, prompt): if inbox != "[]": messages.append({"role": "user", "content": f"{inbox}"}) - messages.append({"role": "assistant", - "content": "Noted inbox messages."}) response = client.messages.create(...) if response.stop_reason != "tool_use": break diff --git a/docs/ja/s08-background-tasks.md b/docs/ja/s08-background-tasks.md index c09be7d..b3fe077 100644 --- a/docs/ja/s08-background-tasks.md +++ b/docs/ja/s08-background-tasks.md @@ -81,8 +81,6 @@ def agent_loop(messages: list): messages.append({"role": "user", "content": f"\n{notif_text}\n" f""}) - messages.append({"role": "assistant", - "content": "Noted background results."}) response = client.messages.create(...) ``` diff --git a/docs/ja/s09-agent-teams.md b/docs/ja/s09-agent-teams.md index 5857df4..671b6e6 100644 --- a/docs/ja/s09-agent-teams.md +++ b/docs/ja/s09-agent-teams.md @@ -93,8 +93,6 @@ def _teammate_loop(self, name, role, prompt): if inbox != "[]": messages.append({"role": "user", "content": f"{inbox}"}) - messages.append({"role": "assistant", - "content": "Noted inbox messages."}) response = client.messages.create(...) if response.stop_reason != "tool_use": break diff --git a/docs/zh/s08-background-tasks.md b/docs/zh/s08-background-tasks.md index 418fabc..61da159 100644 --- a/docs/zh/s08-background-tasks.md +++ b/docs/zh/s08-background-tasks.md @@ -81,8 +81,6 @@ def agent_loop(messages: list): messages.append({"role": "user", "content": f"\n{notif_text}\n" f""}) - messages.append({"role": "assistant", - "content": "Noted background results."}) response = client.messages.create(...) ``` diff --git a/docs/zh/s09-agent-teams.md b/docs/zh/s09-agent-teams.md index f420651..ebb3892 100644 --- a/docs/zh/s09-agent-teams.md +++ b/docs/zh/s09-agent-teams.md @@ -93,8 +93,6 @@ def _teammate_loop(self, name, role, prompt): if inbox != "[]": messages.append({"role": "user", "content": f"{inbox}"}) - messages.append({"role": "assistant", - "content": "Noted inbox messages."}) response = client.messages.create(...) if response.stop_reason != "tool_use": break