From 100eaa98554a9d33714c72aba95d40ad5c857ea4 Mon Sep 17 00:00:00 2001 From: likewise Date: Thu, 5 Feb 2004 19:13:33 +0000 Subject: [PATCH] Removed updating ARP cache using destination address (which is wrong for requests and replies are unicast anyway). --- src/netif/etharp.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/netif/etharp.c b/src/netif/etharp.c index c4504ecc..ebbabfbc 100644 --- a/src/netif/etharp.c +++ b/src/netif/etharp.c @@ -528,11 +528,8 @@ etharp_arp_input(struct netif *netif, struct eth_addr *ethaddr, struct pbuf *p) update_arp_entry(netif, &(hdr->sipaddr), &(hdr->shwaddr), ARP_INSERT_FLAG); /* request was not directed to us, but snoop anyway */ } else { - /* update or insert the source IP address in the cache */ + /* update the source IP address in the cache */ update_arp_entry(netif, &(hdr->sipaddr), &(hdr->shwaddr), 0); - /* update or insert the destination IP address pair in the cache */ - /** TODO: this might not work for an ARP request! TODO: Check **/ - update_arp_entry(netif, &(hdr->dipaddr), &(hdr->dhwaddr), 0); } switch (htons(hdr->opcode)) {