From 1147b9ce3873792fe3cb75d39c83ee35146eb64c Mon Sep 17 00:00:00 2001 From: Joel Cunningham Date: Wed, 8 Nov 2017 14:42:28 -0600 Subject: [PATCH] test_dhcp: set link up on net_test netif DHCP test code didn't set link up on net_test netif (exposed by changes in 637bce91b45c855964f549f91bc41a32317eac4c) Then during the test_dhcp function, a Gratuitous ARP was not sent during the call to dhcp_bind() because the link was still down The sets the link state for all DHCP test functions --- test/unit/dhcp/test_dhcp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/unit/dhcp/test_dhcp.c b/test/unit/dhcp/test_dhcp.c index 1b0c8843..1b6d974a 100644 --- a/test/unit/dhcp/test_dhcp.c +++ b/test/unit/dhcp/test_dhcp.c @@ -448,6 +448,7 @@ START_TEST(test_dhcp) IP4_ADDR(&gw, 0, 0, 0, 0); netif_add(&net_test, &addr, &netmask, &gw, &net_test, testif_init, ethernet_input); + netif_set_link_up(&net_test); netif_set_up(&net_test); dhcp_start(&net_test); @@ -520,6 +521,7 @@ START_TEST(test_dhcp_nak) IP4_ADDR(&gw, 0, 0, 0, 0); netif_add(&net_test, &addr, &netmask, &gw, &net_test, testif_init, ethernet_input); + netif_set_link_up(&net_test); netif_set_up(&net_test); dhcp_start(&net_test); @@ -741,6 +743,7 @@ START_TEST(test_dhcp_relayed) IP4_ADDR(&gw, 0, 0, 0, 0); netif_add(&net_test, &addr, &netmask, &gw, &net_test, testif_init, ethernet_input); + netif_set_link_up(&net_test); netif_set_up(&net_test); dhcp_start(&net_test); @@ -882,6 +885,7 @@ START_TEST(test_dhcp_nak_no_endmarker) IP4_ADDR(&gw, 0, 0, 0, 0); netif_add(&net_test, &addr, &netmask, &gw, &net_test, testif_init, ethernet_input); + netif_set_link_up(&net_test); netif_set_up(&net_test); dhcp_start(&net_test); @@ -981,6 +985,7 @@ START_TEST(test_dhcp_invalid_overload) IP4_ADDR(&gw, 0, 0, 0, 0); netif_add(&net_test, &addr, &netmask, &gw, &net_test, testif_init, ethernet_input); + netif_set_link_up(&net_test); netif_set_up(&net_test); dhcp_start(&net_test);