abc/lwip
1
0
Fork 0
mirror of https://git.savannah.nongnu.org/git/lwip.git synced 2025-08-08 23:44:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix community string length copying - correctly handle long strings

Browse Source
This commit is contained in:
Dirk Ziegelmeier 2017-03-30 11:09:35 +02:00
parent 8d149e63a6
commit 2673e635a3
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/apps/snmp/snmp_msg.c
View File

@ -821,8 +821,9 @@ snmp_parse_inbound_frame(struct snmp_request *request)
/* SNMPv3 doesn't use communities */ /* SNMPv3 doesn't use communities */
/* @todo: Differentiate read/write access */ /* @todo: Differentiate read/write access */
strncpy((char*)request->community, snmp_community, sizeof(request->community)); strncpy((char*)request->community, snmp_community, SNMP_MAX_COMMUNITY_STR_LEN);
request->community_strlen = (u16_t)strnlen((char*)request->community, sizeof(request->community)); request->community[SNMP_MAX_COMMUNITY_STR_LEN] = 0; /* ensure NULL termination (strncpy does NOT guarantee it!) */
request->community_strlen = (u16_t)strnlen((char*)request->community, SNMP_MAX_COMMUNITY_STR_LEN);
/* RFC3414 globalData */ /* RFC3414 globalData */
IF_PARSE_EXEC(snmp_asn1_dec_tlv(&pbuf_stream, &tlv)); IF_PARSE_EXEC(snmp_asn1_dec_tlv(&pbuf_stream, &tlv));