From 5ddd2aef4b44f9a871a8ea387d0e2e1b6f542163 Mon Sep 17 00:00:00 2001 From: Dirk Ziegelmeier Date: Thu, 29 Sep 2016 08:25:57 +0200 Subject: [PATCH] Substitute custom itoa implementation mdns by lwip_itoa() and strlen() call --- src/apps/mdns/mdns.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/apps/mdns/mdns.c b/src/apps/mdns/mdns.c index 110affb4..085bebd4 100644 --- a/src/apps/mdns/mdns.c +++ b/src/apps/mdns/mdns.c @@ -470,15 +470,11 @@ mdns_build_reverse_v4_domain(struct mdns_domain *domain, const ip4_addr_t *addr) memset(domain, 0, sizeof(struct mdns_domain)); ptr = (const u8_t *) addr; for (i = sizeof(ip4_addr_t) - 1; i >= 0; i--) { - char buf[3]; - size_t pos = sizeof(buf); + char buf[4]; u8_t val = ptr[i]; - do { - pos--; - buf[pos] = '0' + (val % 10); - val /= 10; - } while (val != 0); /* loop is correct because u8_t needs at most 3 chars */ - res = mdns_domain_add_label(domain, &buf[pos], (u8_t)(3 - pos)); + + lwip_itoa(buf, sizeof(buf), val); + res = mdns_domain_add_label(domain, buf, (u8_t)strlen(buf)); LWIP_ERROR("mdns_build_reverse_v4_domain: Failed to add label", (res == ERR_OK), return res); } res = mdns_domain_add_label(domain, REVERSE_PTR_V4_DOMAIN, (u8_t)(sizeof(REVERSE_PTR_V4_DOMAIN)-1));