Ongoing fix to patch #5822: converted more statements like (void)arg; into LWIP_UNUSED_ARG(arg);

src/api/tcpip.c

@@ -57,7 +57,7 @@ static int tcpip_tcp_timer_active = 0;
 static void
 tcpip_tcp_timer(void *arg)
 {
-  (void)arg;
+  LWIP_UNUSED_ARG(arg);
 
   /* call TCP timer handler */
   tcp_tmr();

src/core/tcp.c

@@ -283,9 +283,9 @@ tcp_bind(struct tcp_pcb *pcb, struct ip_addr *ipaddr, u16_t port)
 static err_t
 tcp_accept_null(void *arg, struct tcp_pcb *pcb, err_t err)
 {
-  (void)arg;
+  LWIP_UNUSED_ARG(arg);
-  (void)pcb;
+  LWIP_UNUSED_ARG(pcb);
-  (void)err;
+  LWIP_UNUSED_ARG(err);
 
   return ERR_ABRT;
 }

src/netif/ppp/auth.c

@@ -747,7 +747,7 @@ static void check_idle(void *arg)
     struct ppp_idle idle;
     u_short itime;
     
-	(void)arg;
+    LWIP_UNUSED_ARG(arg);
     if (!get_idle_time(0, &idle))
         return;
     itime = LWIP_MIN(idle.xmit_idle, idle.recv_idle);
@@ -765,7 +765,7 @@ static void check_idle(void *arg)
  */
 static void connect_time_expired(void *arg)
 {
-	(void)arg;
+    LWIP_UNUSED_ARG(arg);
 
     AUTHDEBUG((LOG_INFO, "Connect time expired\n"));
     lcp_close(0, "Connect time expired");   /* Close connection */
@@ -804,7 +804,7 @@ static void logout(void)
  */
 static int null_login(int unit)
 {
-	(void)unit;
+    LWIP_UNUSED_ARG(unit);
     /* XXX Fail until we decide that we want to support logins. */
     return 0;
 }
@@ -850,9 +850,9 @@ static int have_pap_secret(void)
  */
 static int have_chap_secret(char *client, char *server, u32_t remote)
 {
-	(void)client;
+    LWIP_UNUSED_ARG(client);
-	(void)server;
+    LWIP_UNUSED_ARG(server);
-	(void)remote;
+    LWIP_UNUSED_ARG(remote);
     /* XXX Fail until we set up our passwords. */
     return 0;
 }

src/netif/ppp/ipcp.c

@@ -1321,10 +1321,10 @@ static int ipcp_printpkt(
 	void *arg
 )
 {
-	(void)p;
+	LWIP_UNUSED_ARG(p);
-	(void)plen;
+	LWIP_UNUSED_ARG(plen);
-	(void)printer;
+	LWIP_UNUSED_ARG(printer);
-	(void)arg;
+	LWIP_UNUSED_ARG(arg);
 	return 0;
 }
 

src/netif/ppp/lcp.c

@@ -457,7 +457,7 @@ static void lcp_rprotrej(fsm *f, u_char *inp, int len)
  */
 static void lcp_protrej(int unit)
 {
-	(void)unit;
+	LWIP_UNUSED_ARG(unit);
 	/*
 	* Can't reject LCP!
 	*/
@@ -1908,7 +1908,7 @@ static void lcp_received_echo_reply (fsm *f, int id, u_char *inp, int len)
 {
 	u32_t magic;
 	
-	(void)id;
+	LWIP_UNUSED_ARG(id);
 
 	/* Check the magic number - don't count replies from ourselves. */
 	if (len < 4) {

src/netif/ppp/pap.c

@@ -596,10 +596,10 @@ static int upap_printpkt(
 	void *arg
 )
 {
-	(void)p;
+	LWIP_UNUSED_ARG(p);
-	(void)plen;
+	LWIP_UNUSED_ARG(plen);
-	(void)printer;
+	LWIP_UNUSED_ARG(printer);
-	(void)arg;
+	LWIP_UNUSED_ARG(arg);
 	return 0;
 }
 #endif

src/netif/ppp/ppp.c

@@ -546,7 +546,7 @@ static err_t pppifOutput(struct netif *netif, struct pbuf *pb, struct ip_addr *i
     struct pbuf *headMB = NULL, *tailMB = NULL, *p;
     u_char c;
 
-    (void)ipaddr;
+    LWIP_UNUSED_ARG(ipaddr);
 
     /* Validate parameters. */
     /* We let any protocol value go through - it can't hurt us
@@ -865,9 +865,9 @@ void ppp_recv_config(
     PPPControl *pc = &pppControl[unit];
     int i;
     
-	(void)accomp;
+    LWIP_UNUSED_ARG(accomp);
-	(void)pcomp;
+    LWIP_UNUSED_ARG(pcomp);
-	(void)mru;
+    LWIP_UNUSED_ARG(mru);
 
     /* Load the ACCM bits for the 32 control codes. */
     for (i = 0; i < 32 / 8; i++)
@@ -920,8 +920,8 @@ int ccp_fatal_error(int unit)
 int get_idle_time(int u, struct ppp_idle *ip)
 {   
     /* XXX */
-	(void)u;
+    LWIP_UNUSED_ARG(u);
-	(void)ip;
+    LWIP_UNUSED_ARG(ip);
 
     return 0;
 }
@@ -1029,9 +1029,9 @@ int sifup(int pd)
  */
 int sifnpmode(int u, int proto, enum NPmode mode)
 {
-	(void)u;
+    LWIP_UNUSED_ARG(u);
-	(void)proto;
+    LWIP_UNUSED_ARG(proto);
-	(void)mode;
+    LWIP_UNUSED_ARG(mode);
     return 0;
 }
 
@@ -1097,8 +1097,8 @@ int cifaddr(
     PPPControl *pc = &pppControl[pd];
     int st = 1;
     
-	(void)o;
+    LWIP_UNUSED_ARG(o);
-	(void)h;
+    LWIP_UNUSED_ARG(h);
     if (pd < 0 || pd >= NUM_PPP || !pc->openFlag) {
         st = 0;
         PPPDEBUG((LOG_WARNING, "sifup[%d]: bad parms\n", pd));
@@ -1120,8 +1120,8 @@ int sifdefaultroute(int pd, u32_t l, u32_t g)
     PPPControl *pc = &pppControl[pd];
     int st = 1;
     
-	(void)l;
+    LWIP_UNUSED_ARG(l);
-	(void)g;
+    LWIP_UNUSED_ARG(g);
     if (pd < 0 || pd >= NUM_PPP || !pc->openFlag) {
         st = 0;
         PPPDEBUG((LOG_WARNING, "sifup[%d]: bad parms\n", pd));
@@ -1142,8 +1142,8 @@ int cifdefaultroute(int pd, u32_t l, u32_t g)
     PPPControl *pc = &pppControl[pd];
     int st = 1;
     
-	(void)l;
+    LWIP_UNUSED_ARG(l);
-	(void)g;
+    LWIP_UNUSED_ARG(g);
     if (pd < 0 || pd >= NUM_PPP || !pc->openFlag) {
         st = 0;
         PPPDEBUG((LOG_WARNING, "sifup[%d]: bad parms\n", pd));