From 8e65fb920f35fd0c73b2c569049cd283eb98368f Mon Sep 17 00:00:00 2001
From: goldsimon <goldsimon>
Date: Fri, 8 Jun 2007 17:24:58 +0000
Subject: [PATCH] loopif_output(): use pbuf_copy() to copy the pbuf to reduce
 code size

---
 src/netif/loopif.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/src/netif/loopif.c b/src/netif/loopif.c
index 91777b50..4d5ae72c 100644
--- a/src/netif/loopif.c
+++ b/src/netif/loopif.c
@@ -125,8 +125,8 @@ loopif_output(struct netif *netif, struct pbuf *p,
   SYS_ARCH_DECL_PROTECT(lev);
   struct loopif_private *priv;
 #endif /* LWIP_LOOPIF_MULTITHREADING */
-  struct pbuf *q, *r;
-  u8_t *ptr;
+  struct pbuf *r;
+  err_t err;
 
   LWIP_UNUSED_ARG(ipaddr);
 
@@ -137,13 +137,10 @@ loopif_output(struct netif *netif, struct pbuf *p,
   }
 
   /* Copy the whole pbuf queue p into the single pbuf r */
-  /* @todo: - extend this so that r can be a pbuf list also
-   *        - could use pbuf_copy() for that!
-   */
-  ptr = r->payload;
-  for(q = p; q != NULL; q = q->next) {
-    MEMCPY(ptr, q->payload, q->len);
-    ptr += q->len;
+  if ((err = pbuf_copy(r, p)) != ERR_OK) {
+    pbuf_free(r);
+    r = NULL;
+    return err;
   }
 
 #if LWIP_LOOPIF_MULTITHREADING