From 93b2074f2b59789103c6873f859082f194404af2 Mon Sep 17 00:00:00 2001 From: Simon Goldschmidt Date: Fri, 7 Sep 2018 21:01:32 +0200 Subject: [PATCH] Remove LWIP_DHCP_CHECK_LINK_UP define as it's useless See bug #54574 Signed-off-by: Simon Goldschmidt --- src/core/ipv4/dhcp.c | 3 --- src/include/lwip/opt.h | 10 ---------- 2 files changed, 13 deletions(-) diff --git a/src/core/ipv4/dhcp.c b/src/core/ipv4/dhcp.c index 24eb059c..534574fe 100644 --- a/src/core/ipv4/dhcp.c +++ b/src/core/ipv4/dhcp.c @@ -784,14 +784,11 @@ dhcp_start(struct netif *netif) } dhcp->pcb_allocated = 1; -#if LWIP_DHCP_CHECK_LINK_UP if (!netif_is_link_up(netif)) { /* set state INIT and wait for dhcp_network_changed() to call dhcp_discover() */ dhcp_set_state(dhcp, DHCP_STATE_INIT); return ERR_OK; } -#endif /* LWIP_DHCP_CHECK_LINK_UP */ - /* (re)start the DHCP negotiation */ result = dhcp_discover(netif); diff --git a/src/include/lwip/opt.h b/src/include/lwip/opt.h index f5c8f931..a14645fa 100644 --- a/src/include/lwip/opt.h +++ b/src/include/lwip/opt.h @@ -930,16 +930,6 @@ #define DHCP_DOES_ARP_CHECK (LWIP_DHCP && LWIP_ARP) #endif -/** - * LWIP_DHCP_CHECK_LINK_UP==1: dhcp_start() only really starts if the netif has - * NETIF_FLAG_LINK_UP set in its flags. As this is only an optimization and - * netif drivers might not set this flag, the default is off. If enabled, - * netif_set_link_up() must be called to continue dhcp starting. - */ -#if !defined LWIP_DHCP_CHECK_LINK_UP -#define LWIP_DHCP_CHECK_LINK_UP 0 -#endif - /** * LWIP_DHCP_BOOTP_FILE==1: Store offered_si_addr and boot_file_name. */