From a48ff4aaf2a52423504b5f5d8f3a5cf44aa0e7aa Mon Sep 17 00:00:00 2001 From: Sylvain Rochet Date: Thu, 14 Jun 2018 19:58:41 +0200 Subject: [PATCH] PPP, PPPoE: fix trivial build error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit lwip/src/netif/ppp/pppoe.c: In function ‘pppoe_send_padt’: lwip/src/netif/ppp/pppoe.c:1048:108: error: ‘sc’ undeclared (first use in this function) sc is not passed to ‘pppoe_send_padt’ function because it might be called to terminate unknown sessions. Fixes: d4047ea1d185 ("Try to fix issues reported by coverity") Signed-off-by: Sylvain Rochet --- src/netif/ppp/pppoe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/netif/ppp/pppoe.c b/src/netif/ppp/pppoe.c index cd4f650b..8ed2d638 100644 --- a/src/netif/ppp/pppoe.c +++ b/src/netif/ppp/pppoe.c @@ -1045,7 +1045,7 @@ pppoe_send_padt(struct netif *outgoing_if, u_int session, const u8_t *dest) LWIP_ASSERT("pb->tot_len == pb->len", pb->tot_len == pb->len); if (pbuf_add_header(pb, sizeof(struct eth_hdr))) { - PPPDEBUG(LOG_ERR, ("pppoe: %c%c%"U16_F": pppoe_send_padt: could not allocate room for PPPoE header\n", sc->sc_ethif->name[0], sc->sc_ethif->name[1], sc->sc_ethif->num)); + PPPDEBUG(LOG_ERR, ("pppoe: pppoe_send_padt: could not allocate room for PPPoE header\n")); LINK_STATS_INC(link.lenerr); pbuf_free(pb); return ERR_BUF;