From bd8709bc824822ee67a6668d2945312e79a0b4d2 Mon Sep 17 00:00:00 2001 From: goldsimon Date: Mon, 21 Aug 2017 22:33:01 +0200 Subject: [PATCH] Simplify pbuf_remove_header() a bit --- src/core/pbuf.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/src/core/pbuf.c b/src/core/pbuf.c index a2daf715..814127f8 100644 --- a/src/core/pbuf.c +++ b/src/core/pbuf.c @@ -593,14 +593,8 @@ pbuf_remove_header(struct pbuf *p, size_t header_size_decrement) payload = p->payload; LWIP_UNUSED_ARG(payload); /* only used in LWIP_DEBUGF below */ - if (increment_magnitude <= p->len) { - /* increase payload pointer */ - p->payload = (u8_t *)p->payload + header_size_decrement; - } else { - /* cannot expand payload to front (yet!) - * bail out unsuccessfully */ - return 1; - } + /* increase payload pointer (guarded by length check above) */ + p->payload = (u8_t *)p->payload + header_size_decrement; /* modify pbuf length fields */ p->len = (u16_t)(p->len - increment_magnitude); p->tot_len = (u16_t)(p->tot_len - increment_magnitude);