From ca76c302f16c80389ca9cc30a77f7c381cf45a12 Mon Sep 17 00:00:00 2001 From: Dirk Ziegelmeier Date: Fri, 28 Jul 2017 08:01:30 +0200 Subject: [PATCH] Probably fix bug #51602: MQTT Ring buffer 'get' Rollover of get index was wrong --- src/apps/mqtt/mqtt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/mqtt/mqtt.c b/src/apps/mqtt/mqtt.c index 49367e78..1adcab0b 100644 --- a/src/apps/mqtt/mqtt.c +++ b/src/apps/mqtt/mqtt.c @@ -204,7 +204,7 @@ mqtt_ringbuf_advance_get_idx(struct mqtt_ringbuf_t *rb, u16_t len) LWIP_ASSERT("mqtt_ringbuf_advance_get_idx: len < MQTT_OUTPUT_RINGBUF_SIZE", len < MQTT_OUTPUT_RINGBUF_SIZE); rb->get += len; - if (rb->get > MQTT_OUTPUT_RINGBUF_SIZE) { + if (rb->get >= MQTT_OUTPUT_RINGBUF_SIZE) { rb->get = rb->get - MQTT_OUTPUT_RINGBUF_SIZE; } }