Minor changes (but in lot of files): add #if/#endif for options where they could miss. #if LWIP_xxx if always put after #include "lwip/opt.h" (note this one indirectly include cc.h). Move others includes inside #if/#endif block.

src/core/snmp/asn1_dec.c

@@ -36,7 +36,8 @@
 
 #include "lwip/opt.h"
 
-#if LWIP_SNMP
+#if LWIP_SNMP /* don't build if not configured for use in lwipopts.h */
+
 #include "lwip/snmp_asn1.h"
 
 /**
@@ -654,4 +655,3 @@ snmp_asn1_dec_raw(struct pbuf *p, u16_t ofs, u16_t len, u16_t raw_len, u8_t *raw
 }
 
 #endif /* LWIP_SNMP */
-

src/core/snmp/asn1_enc.c

@@ -36,7 +36,8 @@
 
 #include "lwip/opt.h"
 
-#if LWIP_SNMP
+#if LWIP_SNMP /* don't build if not configured for use in lwipopts.h */
+
 #include "lwip/snmp_asn1.h"
 
 /**

src/core/snmp/mib2.c

@@ -37,17 +37,17 @@
 
 #include "lwip/opt.h"
 
-#if LWIP_SNMP
+#if LWIP_SNMP /* don't build if not configured for use in lwipopts.h */
 
 #include "lwip/snmp.h"
 #include "lwip/netif.h"
-#include "netif/etharp.h"
 #include "lwip/ip.h"
 #include "lwip/ip_frag.h"
 #include "lwip/tcp.h"
 #include "lwip/udp.h"
 #include "lwip/snmp_asn1.h"
 #include "lwip/snmp_structs.h"
+#include "netif/etharp.h"
 
 /**
  * IANA assigned enterprise ID for lwIP is 26381

src/core/snmp/mib_structs.c

@@ -34,12 +34,11 @@
 
 #include "lwip/opt.h"
 
-#if LWIP_SNMP
+#if LWIP_SNMP /* don't build if not configured for use in lwipopts.h */
+
 #include "lwip/snmp_structs.h"
 #include "lwip/mem.h"
 
-
-
 /** .iso.org.dod.internet address prefix, @see snmp_iso_*() */
 const s32_t prefix[4] = {1, 3, 6, 1};
 
@@ -1182,4 +1181,3 @@ snmp_iso_prefix_expand(u8_t ident_len, s32_t *ident, struct snmp_obj_id *oidret)
 }
 
 #endif /* LWIP_SNMP */
-

src/core/snmp/msg_in.c

@@ -34,19 +34,18 @@
 
 #include "lwip/opt.h"
 
-#if LWIP_SNMP
+#if LWIP_SNMP /* don't build if not configured for use in lwipopts.h */
 
-#include <string.h>
 #include "lwip/ip_addr.h"
 #include "lwip/mem.h"
 #include "lwip/udp.h"
 #include "lwip/stats.h"
-
 #include "lwip/snmp.h"
 #include "lwip/snmp_asn1.h"
 #include "lwip/snmp_msg.h"
 #include "lwip/snmp_structs.h"
 
+#include <string.h>
 
 /* public (non-static) constants */
 /** SNMP v1 == 0 */

src/core/snmp/msg_out.c

@@ -44,11 +44,10 @@
 
 #include "lwip/opt.h"
 
-#if LWIP_SNMP
+#if LWIP_SNMP /* don't build if not configured for use in lwipopts.h */
 
 #include "lwip/udp.h"
 #include "lwip/netif.h"
-
 #include "lwip/snmp.h"
 #include "lwip/snmp_asn1.h"
 #include "lwip/snmp_msg.h"