171 Commits

Author SHA1 Message Date
Sylvain Rochet
33e8472473 CHAP auth is now working 2012-05-17 19:05:47 +02:00
Sylvain Rochet
8834a8b216 using UNTIMEOUT macro instead of timeout() 2012-05-17 16:36:59 +02:00
Sylvain Rochet
db794c2d32 PPPoL2TP patch from Debian, not used yet, but already fixed 2012-05-17 16:29:00 +02:00
Sylvain Rochet
a1d80c29de fixed demand_rexmit() with new IP addr, maybe we will never support demand or drop it, but it is already patched just in case 2012-05-17 16:23:32 +02:00
Sylvain Rochet
bea796ebc0 pppd: Terminate correctly if lcp_lowerup delayed calling fsm_lowerup 2012-05-17 16:14:30 +02:00
Sylvain Rochet
d4978210f0 using rp-pppoe pppd exits with EXIT_OK after receiving a timeout waiting for PADO due to no modem attached, from Debian patches
http://ppp.samba.org/cgi-bin/ppp-bugs/incoming?id=2211

Using rp-pppoe pppd exits with exitcode 0, whenever there is no modem connected
and pppd get's a timeout while waiting for a PADO.

This happens because status is set to EXIT_OK in main.c at the beginning of the
procedures. Within start_link(), connect() will be called as one of the first
calls.
If that call fails (no pppoe discovery for example), jumps to "fail", which
returns without setting the status variable to failure. So at the end pppd exits
with EXIT_OK.

I moved the status = EXIT_NEGOTIATION_FAILED which will be set later within
start_link, at the top of it. That seems to work out, patch is attached:
2012-05-17 15:56:35 +02:00
Sylvain Rochet
ef59e952d8 added IPCP no/replace default route option from Debian patches, I like the idea 2012-05-17 15:55:27 +02:00
Sylvain Rochet
54d5ee5562 added LCP adaptive echo from Debian patches, I like the idea 2012-05-17 15:50:15 +02:00
Sylvain Rochet
eb75ae05c6 Early development stage of an attempt to port PPPd 2.4.5 to lwIP.
PPPoE works, PPPoS code is not ported at all.

I am using the RP-PPPoE server to do my tests using the following
configuration:

$ cat /etc/ppp/pppoe-server-options
debug
login
lcp-echo-interval 10
lcp-echo-failure 10
ms-dns 192.168.4.130
ms-dns 192.168.4.231
netmask 255.255.255.0
defaultroute
noipdefault
usepeerdns

$ cat /etc/ppp/allip
192.168.4.1-200

$ pppoe-server -C isp -L 192.168.4.254 -p /etc/ppp/allip -I tap0

Plus the usual auth-lines in /etc/ppp/pap-secrets and
/etc/ppp/chap-secrets .

And the unix port minimal "echo" project slightly modified to use
the "tcpip" API, so with threads, which I am going to commit with
NO_SYS as a -Dmacro.

It still use some of the linux'ism, such as syslog() and crypt(),

I do not want to drop the syslog() supports at the moment, this is
pretty useful to debug, and we may just convert the way the syslog() is
done to provide a trace feature to our PPP users, as a compile-time
option.
2012-05-16 02:02:02 +02:00
goldsimon
3e41f36ef5 Added a readme.txt about the PPP code. 2012-05-07 22:12:01 +02:00
goldsimon
3ac81e9d7c patch by Sylvain Rochet: fixed bug #36283 (PPP struct used on header size computation and not packed) 2012-05-03 20:39:43 +02:00
goldsimon
fb07a28c99 fixed bug #36388 (PPP: checksum-only in last pbuf leads to pbuf with zero length) 2012-05-03 19:45:22 +02:00
goldsimon
e5d54f5344 fixed bug #35756 header length calculation problem in ppp/vj.c - removed unused/invalid defines TCPH_OFFSET(_SET). 2012-03-27 20:42:46 +02:00
goldsimon
0e7df4b193 Removed unnecessary global variable "subnetMask", which is only used in one function (GetMask) 2012-03-12 16:42:18 +01:00
goldsimon
2c9b3b35d1 patch by Bostjan Meglic: fixed bug #35809: PPP GetMask(): Compiler warning on big endian, possible bug on little endian system 2012-03-12 16:39:52 +01:00
goldsimon
ac2175fa7d fixed pbuf leak when PPP session is aborted through pppSigHUP() (bug #35541: PPP Memory Leak) 2012-02-16 12:55:14 +01:00
Ivan Delamer
b3ffa16315 Use pppRecvWakeup only if PPP_INPROC_OWNTHREAD is defined.
Change-Id: Ie800289eb5f6a64d0be1d38eab7154d4aa473d57
2011-10-28 16:22:54 -06:00
Ivan Delamer
09d1f55bce Conditional compilation in ppp.c according to PPP_ options.
Change-Id: I466ce2b0114c9428f5e21bd0a09bb221f40bfc3e
2011-10-28 14:23:20 -06:00
Simon Goldschmidt
d6227aece6 splitted ppp.h to an internal and external header file to get a clear separation of which functions an application or port may use (task #11281) 2011-09-11 19:30:28 +02:00
goldsimon
f3c1686a40 replaced tab with spaces 2011-05-16 18:45:51 +00:00
goldsimon
b5dd87b184 Fixed bug #32280 (ppp: a pbuf is freed twice) 2011-03-27 13:58:26 +00:00
goldsimon
3f849848a4 Fixed bug #32648 (PPP code crashes when terminating a link) by only calling sio_read_abort() if the file descriptor is valid. 2011-03-22 20:59:49 +00:00
goldsimon
856ccb5bb7 Added missing U/UL modifiers to fix 16-bit-arch portability. 2011-02-18 13:31:28 +00:00
goldsimon
229137cad1 Applied patch #7264 (PPP protocols are rejected incorrectly on big endian architectures) 2010-08-01 11:15:48 +00:00
goldsimon
dae247809b Add preprocessor-macros for compile-time htonl calculation (and use them throughout the stack where applicable) 2010-05-16 15:57:42 +00:00
goldsimon
290bd400c3 No need to call pppoe_init any more (since the linked list is implicitly initialized to zero by the loader) 2010-05-16 14:35:03 +00:00
goldsimon
5d0785e47a PPPoE now uses its own MEMP pool instead of the heap (moved struct pppoe_softc from ppp_oe.c to ppp_oe.h) 2010-05-16 14:34:16 +00:00
goldsimon
16434568b0 Use a simple linked list (next pointer) instead of sys/queue.h (from BSD) 2010-05-16 14:24:40 +00:00
goldsimon
c0e7d54e37 Removed 2 mem_mallocs: error string can be a global variable, include memory for sc_ac_cookie in struct pppoe_softc; commented out unused code (sc_service_name/sc_concentrator_name) 2010-05-16 14:11:53 +00:00
goldsimon
f3face9f0c Fix printf-formatter for sio_fd_t/size_t 2010-05-12 07:48:30 +00:00
goldsimon
2edd5230c9 auth_withpeer_fail(): call lcp_close(), like pppd 2.4.5 does 2010-05-11 18:11:46 +00:00
goldsimon
1551bb702d Fixed bug #29855: PPP: Backport a bugfix in LcpSendEchoRequest from pppd 2010-05-11 16:53:41 +00:00
goldsimon
f1bc73c3ed Fixed compilation errors 2010-04-02 16:48:53 +00:00
goldsimon
a96fa7d221 Fixed compilation of debug log code (that is currently commented out) 2010-04-02 16:17:51 +00:00
goldsimon
d47a04456b bug #29105: Review printf formatters 2010-03-08 17:07:35 +00:00
goldsimon
8d9fa63460 PPP: use LWIP_DEBUGF() instead of ppp_trace() 2010-02-22 20:16:39 +00:00
goldsimon
e934f8aac6 Added/improved comments and debug output; renamed 'pc' to 'pcrx' where appropriate to reflect the variable type 2010-02-22 17:58:05 +00:00
goldsimon
311d16df7d Fixed compilation error after splitting tcp.h/tcp_impl.h 2010-02-22 17:52:09 +00:00
goldsimon
ea78d69c6d Added debug output and missing casts 2010-02-22 17:49:49 +00:00
goldsimon
dfb80c6b86 fixed compilation for LWIp_SNMP && PPP_INPROC_MULTITHREADED 2010-02-14 12:26:01 +00:00
goldsimon
6fe258c6bc task #10154 (PPP: Update snmp in/out counters for tx/rx packets) 2010-02-09 18:21:21 +00:00
goldsimon
28dc5f491c Correctly initialize netif flags in pppifNetifInit 2010-02-05 11:20:49 +00:00
goldsimon
010dc6258e Fixed another compiler warning (missing cast) 2010-02-05 10:35:47 +00:00
goldsimon
a5c5949009 Added missing casts to suppress compiler warnings (this mainly satisfies MSVC - the double casts are a bit ugly but don't hurt...) 2010-02-05 10:09:38 +00:00
goldsimon
d51d6b2d89 Use macros to compare IP addresses 2010-02-05 10:08:49 +00:00
goldsimon
c58dfa2156 Added missing casts to suppress compiler warnings 2010-02-05 10:08:41 +00:00
goldsimon
5d360a6711 Replaced struct ip_addr by typedef ip_addr_t to make changing the actual implementation behind the typedef easier. 2010-02-04 18:47:44 +00:00
goldsimon
9c41e1eea3 Replaced tabs with spaces 2010-01-29 23:04:06 +00:00
goldsimon
5fa0347e64 Cleanly separate the portability file inet.h and its contents from the stack: moved htonX- functions to def.h (and the new def.c - they are not ipv4 dependent), let inet.h depend on ip_addr.h and not the other way round. This fixes bug #28732. 2010-01-29 08:20:32 +00:00
goldsimon
a5463f0400 Moved missing include 2010-01-26 16:09:03 +00:00