Dirk Ziegelmeier
52f448978f
MQTT: Add check that WILL topic length must be > 0
2017-01-08 19:08:54 +01:00
Dirk Ziegelmeier
6d5ddb7139
MQTT: Fix possible bug in connect message generation that WILL flag can be set without appending a will message
...
The boolean condition of setting the WILL flag differs from that of appending the will message
Found by Axel Lin
(I fixed it the same way as Axel suggested, but I wanted a different commit message)
2017-01-08 19:07:43 +01:00
Axel Lin
a2915b7142
mqtt: Slightly improve mqtt_create_request
...
Mainly for better readability, also save NULL test while iterating the for loop.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-01-07 20:39:41 +01:00
Axel Lin
7faa4bcbe2
mqtt: Prevent NULL pointer dereference before assertion checking
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-01-06 12:15:03 +01:00
Erik Ekman
d2631e6a53
mqtt: Fix pedantic enum warning
...
src/apps/mqtt/mqtt.c:81:17: error: comma at end of enumerator list [-Werror=pedantic]
2017-01-04 00:24:00 +01:00
Dirk Ziegelmeier
2096f1a657
Fix C++ style comment in mqtt.c
2017-01-01 20:23:11 +01:00
Axel Lin
edfeab7932
mqtt: Trivial coding style fix
...
Add proper blank for if/for/while statements.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2017-01-01 19:20:24 +01:00
Dirk Ziegelmeier
1466b7ac61
Several mqtt documentation fixes found by clang
2016-12-29 09:44:07 +01:00
Axel Lin
bfa0358a52
mqtt: Allow setting server port to connect
...
This is a mqtt client, so it does not make sense to determinate the server port
at compile time. Update mqtt_client_connect() function to allow setting server
port.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-23 09:52:31 +01:00
Dirk Ziegelmeier
3a557baedd
Move a few MQTT options from mqtt.c to mqtt_opts.h
2016-12-21 09:42:25 +01:00
Dirk Ziegelmeier
6e219b6b11
Change signature of mqtt_client_connect() to take an IP addr instead of a string
2016-12-21 09:36:28 +01:00
Dirk Ziegelmeier
ec1450bac4
Add mqtt documentation from Erik Anderson, rev 4b84fff
2016-12-21 09:29:47 +01:00
Axel Lin
5be91de56c
mqtt: Trivial error message fix
...
Fix trivial copy-paste mistake.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-21 08:54:57 +01:00
Axel Lin
d5bc856f45
mqtt: Check conn_state before create request for sub_unsub
...
This also avoid a request leak in client->conn_state == TCP_DISCONNECTED error
path.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-20 19:45:31 +01:00
Dirk Ziegelmeier
16b895b466
Undo removal of mqtt_publish() from documentation in Simon's last commit (guess it was by accident)
2016-12-20 10:48:19 +01:00
Dirk Ziegelmeier
dcb761637d
Minor documentation fix in MQTT
2016-12-20 10:42:56 +01:00
Axel Lin
02f4610b1c
mqtt: Use LWIP_ARRAYSIZE to replace hardcoded value
...
Signed-off-by: Axel Lin <axel.lin@ingics.com>
2016-12-20 10:36:42 +01:00
goldsimon
b6a131edfb
mqtt: fix C usage (declaration after statement), fix casting to smaller type
2016-12-20 10:27:43 +01:00
Dirk Ziegelmeier
12bc2c0425
MQTT cleanups:
...
- create mqtt_opts.h file and move options in there
- documentation cleanups
2016-12-20 10:08:50 +01:00
Dirk Ziegelmeier
14e36866f5
Some cleanups in MQTT client
...
Integrate in documentation
Compile fixes, mostly: Variables must be declared before any statement in a function
2016-12-20 09:41:21 +01:00
Dirk Ziegelmeier
1e82465766
task #14281 : Add MQTT client
...
Thanks to Erik Andersen
Taken from https://github.com/erian747/ , branch mqtt, rev 5d59470
2016-12-20 09:16:21 +01:00
