mirror of
https://github.com/shareAI-lab/analysis_claude_code.git
synced 2026-05-06 16:26:16 +08:00
fix: remove hardcoded assistant acks after system message injection
s08/s09/s10/s11/s_full inject background-results and inbox as user messages before LLM calls. The paired hardcoded assistant "Noted..." responses were unnecessary — consecutive user messages work fine and the fake acks added noise with no functional value. Affected: agents/s08, s09, s10, s11, s_full + docs (zh/en/ja s08, s09)
This commit is contained in:
@@ -194,7 +194,6 @@ def agent_loop(messages: list):
|
|||||||
f"[bg:{n['task_id']}] {n['status']}: {n['result']}" for n in notifs
|
f"[bg:{n['task_id']}] {n['status']}: {n['result']}" for n in notifs
|
||||||
)
|
)
|
||||||
messages.append({"role": "user", "content": f"<background-results>\n{notif_text}\n</background-results>"})
|
messages.append({"role": "user", "content": f"<background-results>\n{notif_text}\n</background-results>"})
|
||||||
messages.append({"role": "assistant", "content": "Noted background results."})
|
|
||||||
response = client.messages.create(
|
response = client.messages.create(
|
||||||
model=MODEL, system=SYSTEM, messages=messages,
|
model=MODEL, system=SYSTEM, messages=messages,
|
||||||
tools=TOOLS, max_tokens=8000,
|
tools=TOOLS, max_tokens=8000,
|
||||||
|
|||||||
@@ -350,10 +350,6 @@ def agent_loop(messages: list):
|
|||||||
"role": "user",
|
"role": "user",
|
||||||
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
|
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
|
||||||
})
|
})
|
||||||
messages.append({
|
|
||||||
"role": "assistant",
|
|
||||||
"content": "Noted inbox messages.",
|
|
||||||
})
|
|
||||||
response = client.messages.create(
|
response = client.messages.create(
|
||||||
model=MODEL,
|
model=MODEL,
|
||||||
system=SYSTEM,
|
system=SYSTEM,
|
||||||
|
|||||||
@@ -431,10 +431,6 @@ def agent_loop(messages: list):
|
|||||||
"role": "user",
|
"role": "user",
|
||||||
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
|
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
|
||||||
})
|
})
|
||||||
messages.append({
|
|
||||||
"role": "assistant",
|
|
||||||
"content": "Noted inbox messages.",
|
|
||||||
})
|
|
||||||
response = client.messages.create(
|
response = client.messages.create(
|
||||||
model=MODEL,
|
model=MODEL,
|
||||||
system=SYSTEM,
|
system=SYSTEM,
|
||||||
|
|||||||
@@ -515,10 +515,6 @@ def agent_loop(messages: list):
|
|||||||
"role": "user",
|
"role": "user",
|
||||||
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
|
"content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>",
|
||||||
})
|
})
|
||||||
messages.append({
|
|
||||||
"role": "assistant",
|
|
||||||
"content": "Noted inbox messages.",
|
|
||||||
})
|
|
||||||
response = client.messages.create(
|
response = client.messages.create(
|
||||||
model=MODEL,
|
model=MODEL,
|
||||||
system=SYSTEM,
|
system=SYSTEM,
|
||||||
|
|||||||
@@ -664,12 +664,10 @@ def agent_loop(messages: list):
|
|||||||
if notifs:
|
if notifs:
|
||||||
txt = "\n".join(f"[bg:{n['task_id']}] {n['status']}: {n['result']}" for n in notifs)
|
txt = "\n".join(f"[bg:{n['task_id']}] {n['status']}: {n['result']}" for n in notifs)
|
||||||
messages.append({"role": "user", "content": f"<background-results>\n{txt}\n</background-results>"})
|
messages.append({"role": "user", "content": f"<background-results>\n{txt}\n</background-results>"})
|
||||||
messages.append({"role": "assistant", "content": "Noted background results."})
|
|
||||||
# s10: check lead inbox
|
# s10: check lead inbox
|
||||||
inbox = BUS.read_inbox("lead")
|
inbox = BUS.read_inbox("lead")
|
||||||
if inbox:
|
if inbox:
|
||||||
messages.append({"role": "user", "content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>"})
|
messages.append({"role": "user", "content": f"<inbox>{json.dumps(inbox, indent=2)}</inbox>"})
|
||||||
messages.append({"role": "assistant", "content": "Noted inbox messages."})
|
|
||||||
# LLM call
|
# LLM call
|
||||||
response = client.messages.create(
|
response = client.messages.create(
|
||||||
model=MODEL, system=SYSTEM, messages=messages,
|
model=MODEL, system=SYSTEM, messages=messages,
|
||||||
|
|||||||
@@ -81,8 +81,6 @@ def agent_loop(messages: list):
|
|||||||
messages.append({"role": "user",
|
messages.append({"role": "user",
|
||||||
"content": f"<background-results>\n{notif_text}\n"
|
"content": f"<background-results>\n{notif_text}\n"
|
||||||
f"</background-results>"})
|
f"</background-results>"})
|
||||||
messages.append({"role": "assistant",
|
|
||||||
"content": "Noted background results."})
|
|
||||||
response = client.messages.create(...)
|
response = client.messages.create(...)
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -93,8 +93,6 @@ def _teammate_loop(self, name, role, prompt):
|
|||||||
if inbox != "[]":
|
if inbox != "[]":
|
||||||
messages.append({"role": "user",
|
messages.append({"role": "user",
|
||||||
"content": f"<inbox>{inbox}</inbox>"})
|
"content": f"<inbox>{inbox}</inbox>"})
|
||||||
messages.append({"role": "assistant",
|
|
||||||
"content": "Noted inbox messages."})
|
|
||||||
response = client.messages.create(...)
|
response = client.messages.create(...)
|
||||||
if response.stop_reason != "tool_use":
|
if response.stop_reason != "tool_use":
|
||||||
break
|
break
|
||||||
|
|||||||
@@ -81,8 +81,6 @@ def agent_loop(messages: list):
|
|||||||
messages.append({"role": "user",
|
messages.append({"role": "user",
|
||||||
"content": f"<background-results>\n{notif_text}\n"
|
"content": f"<background-results>\n{notif_text}\n"
|
||||||
f"</background-results>"})
|
f"</background-results>"})
|
||||||
messages.append({"role": "assistant",
|
|
||||||
"content": "Noted background results."})
|
|
||||||
response = client.messages.create(...)
|
response = client.messages.create(...)
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -93,8 +93,6 @@ def _teammate_loop(self, name, role, prompt):
|
|||||||
if inbox != "[]":
|
if inbox != "[]":
|
||||||
messages.append({"role": "user",
|
messages.append({"role": "user",
|
||||||
"content": f"<inbox>{inbox}</inbox>"})
|
"content": f"<inbox>{inbox}</inbox>"})
|
||||||
messages.append({"role": "assistant",
|
|
||||||
"content": "Noted inbox messages."})
|
|
||||||
response = client.messages.create(...)
|
response = client.messages.create(...)
|
||||||
if response.stop_reason != "tool_use":
|
if response.stop_reason != "tool_use":
|
||||||
break
|
break
|
||||||
|
|||||||
@@ -81,8 +81,6 @@ def agent_loop(messages: list):
|
|||||||
messages.append({"role": "user",
|
messages.append({"role": "user",
|
||||||
"content": f"<background-results>\n{notif_text}\n"
|
"content": f"<background-results>\n{notif_text}\n"
|
||||||
f"</background-results>"})
|
f"</background-results>"})
|
||||||
messages.append({"role": "assistant",
|
|
||||||
"content": "Noted background results."})
|
|
||||||
response = client.messages.create(...)
|
response = client.messages.create(...)
|
||||||
```
|
```
|
||||||
|
|
||||||
|
|||||||
@@ -93,8 +93,6 @@ def _teammate_loop(self, name, role, prompt):
|
|||||||
if inbox != "[]":
|
if inbox != "[]":
|
||||||
messages.append({"role": "user",
|
messages.append({"role": "user",
|
||||||
"content": f"<inbox>{inbox}</inbox>"})
|
"content": f"<inbox>{inbox}</inbox>"})
|
||||||
messages.append({"role": "assistant",
|
|
||||||
"content": "Noted inbox messages."})
|
|
||||||
response = client.messages.create(...)
|
response = client.messages.create(...)
|
||||||
if response.stop_reason != "tool_use":
|
if response.stop_reason != "tool_use":
|
||||||
break
|
break
|
||||||
|
|||||||
Reference in New Issue
Block a user